Closed tripflex closed 10 months ago
Name | Link |
---|---|
Latest commit | 2ff6b73f50cddbaa668252bbd9961c278f58561f |
Latest deploy log | https://app.netlify.com/sites/vite-pwa-org/deploys/64f1dac8af1f5f000884cb8a |
Deploy Preview | https://deploy-preview-81--vite-pwa-org.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
The png is global in the splash entry here: https://github.com/vite-pwa/assets-generator/blob/main/src/types.ts#L91
We should add png to the options in both functions
We should add png to the options in both functions
Ahhh okay i'll remove those changes to docs
The png is global in the splash entry here: https://github.com/vite-pwa/assets-generator/blob/main/src/types.ts#L91
Reverted those commits, this PR is just now for a tip about resizeOptions, which can be closed if we set the default (or adjusted to match accordingly)
@tripflex I'm updating your PR in assets generation and preparing a new PR to inlcude the missing options.
Can you update also the following entries in CLI page here?
resizeOptions: { background: 'white' },
to resizeOptions: { background: 'white', fit: 'contain' },
in both code snippets here iOS/iPad Splash ScreensdarkResizeOptions: {},
to darkResizeOptions: { background: 'black', fit: 'contain' },
in the code snippet here Dark Splash ScreensI'll change PR title later once the assets generator released.
EDIT: I'm working on this... @vite-pwa/assets-generator v0.0.9
released
It seems we don't need the TIP
@tripflex merging this, If you want any other change feel free to send another PR, thx
Added link and tip about resizeOptions for fit