vite-pwa / docs

Documentation: PWA integrations for Vite and the ecosystem
https://vite-pwa-org.netlify.app/
MIT License
196 stars 42 forks source link

docs(assets-generator): include resizeOptions defaults (splash) #81

Closed tripflex closed 10 months ago

tripflex commented 10 months ago

Added link and tip about resizeOptions for fit

netlify[bot] commented 10 months ago

Deploy Preview for vite-pwa-org ready!

Name Link
Latest commit 2ff6b73f50cddbaa668252bbd9961c278f58561f
Latest deploy log https://app.netlify.com/sites/vite-pwa-org/deploys/64f1dac8af1f5f000884cb8a
Deploy Preview https://deploy-preview-81--vite-pwa-org.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

userquin commented 10 months ago

The png is global in the splash entry here: https://github.com/vite-pwa/assets-generator/blob/main/src/types.ts#L91

userquin commented 10 months ago

We should add png to the options in both functions

tripflex commented 10 months ago

We should add png to the options in both functions

Ahhh okay i'll remove those changes to docs

tripflex commented 10 months ago

The png is global in the splash entry here: https://github.com/vite-pwa/assets-generator/blob/main/src/types.ts#L91

Reverted those commits, this PR is just now for a tip about resizeOptions, which can be closed if we set the default (or adjusted to match accordingly)

userquin commented 10 months ago

@tripflex I'm updating your PR in assets generation and preparing a new PR to inlcude the missing options.

Can you update also the following entries in CLI page here?

I'll change PR title later once the assets generator released.

EDIT: I'm working on this... @vite-pwa/assets-generator v0.0.9 released

userquin commented 10 months ago

It seems we don't need the TIP

userquin commented 10 months ago

@tripflex merging this, If you want any other change feel free to send another PR, thx