search

vite-pwa / vite-plugin-pwa

Zero-config PWA for Vite
https://vite-pwa-org.netlify.app/
MIT License
3.22k stars 211 forks source link

fix(dev): inject register not working when disabling web manifest #686

Closed userquin closed 8 months ago

userquin commented 8 months ago

closes #660

netlify[bot] commented 8 months ago

Deploy Preview for vite-plugin-pwa-legacy ready!

Name Link
Latest commit a2a68ab22a8508a2185219ede4498cc697ecec7b
Latest deploy log https://app.netlify.com/sites/vite-plugin-pwa-legacy/deploys/65f44e7cf4c83e00087024d2
Deploy Preview https://deploy-preview-686--vite-plugin-pwa-legacy.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rschristian commented 8 months ago

Gave this a quick test but it doesn't seem to correct the issue, unless I'm being daft (perfectly possible).

userquin commented 8 months ago

Gave this a quick test but it doesn't seem to correct the issue, unless I'm being daft (perfectly possible).

I'm preparing some tests in my local, will take some time...

rschristian commented 8 months ago

No worries or rush! Just thought I'd comment that

userquin commented 8 months ago

I need to change also the transformIndexHtml in the dev plugin

userquin commented 8 months ago

No worries or rush! Just thought I'd comment that

With last commit should work: tested with vanilla-ts-dev-options example.