search

vite-pwa / vite-plugin-pwa

Zero-config PWA for Vite
https://vite-pwa-org.netlify.app/
MIT License
2.84k stars 192 forks source link

fix: ensure base path ends with forward slash #710

Open PanMisza opened 3 weeks ago

PanMisza commented 3 weeks ago

Right now, this plugin assumes that the base path always ends with a forward slash (/). However, this is not always the case.

When we set the base as, for example /app, the browser will try to download /appmanifest.webmanifest and /appsw.js

This PR resolves that case.

netlify[bot] commented 3 weeks ago

Deploy Preview for vite-plugin-pwa-legacy ready!

Name Link
Latest commit 1892bedf6c99327ea0ed1b97e56fe1c45e9e461b
Latest deploy log https://app.netlify.com/sites/vite-plugin-pwa-legacy/deploys/6637da963c0aef00087e5833
Deploy Preview https://deploy-preview-710--vite-plugin-pwa-legacy.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.