Open Jinjiang opened 6 months ago
When modifying files inside node_modules, the HMR doesn't work.
I guess it's because this line of code reject the following logics https://github.com/vitejs/vite-plugin-react/blob/main/packages/plugin-react/src/index.ts#L165
async transform(code, id, options) { if (id.includes('/node_modules/')) return ... }
Maybe it could be simply combined with opt.include to let those files pass.
opt.include
Thanks.
https://github.com/Jinjiang/reproductions/tree/vite-react-hmr-202404
pnpm install
pnpm dev
node_modules/foo/index.mjs
System: OS: macOS 14.4.1 CPU: (8) arm64 Apple M1 Memory: 79.17 MB / 8.00 GB Shell: 5.9 - /bin/zsh Binaries: Node: 20.11.1 - ~/.local/share/mise/installs/node/20/bin/node Yarn: 1.22.18 - ~/.yarn/bin/yarn npm: 10.2.4 - ~/.local/share/mise/installs/node/20/bin/npm pnpm: 8.15.5 - ~/Library/pnpm/pnpm bun: 1.0.29 - ~/.local/share/mise/installs/bun/latest/bin/bun Browsers: Safari: 17.4.1 npmPackages: @vitejs/plugin-react: ^4.2.1 => 4.2.1 vite: ^5.2.8 => 5.2.8
pnpm
No response
Describe the bug
When modifying files inside node_modules, the HMR doesn't work.
I guess it's because this line of code reject the following logics https://github.com/vitejs/vite-plugin-react/blob/main/packages/plugin-react/src/index.ts#L165
Maybe it could be simply combined with
opt.include
to let those files pass.Thanks.
Reproduction
https://github.com/Jinjiang/reproductions/tree/vite-react-hmr-202404
Steps to reproduce
pnpm install
andpnpm dev
node_modules/foo/index.mjs
to see whether the page is reloadedSystem Info
Used Package Manager
pnpm
Logs
No response
Validations