search

vitejs / vite-plugin-vue2

Vite plugin for Vue 2.7
MIT License
551 stars 47 forks source link

bugfix/assetUrlOptions #48

Closed ZeroThe2nd closed 2 years ago

ZeroThe2nd commented 2 years ago

This fixes #47

Changes:

Note:

I could not find anything on "how-to-commit" or house-rules of how a PR is supposed to be made. Also running the ppm changeling command added things I did not change myself, so I (for now) did not add this in my commit and PR.

Test have been run, all of them passed (1 test file, 18 tests in total). I've also tried the previously failing production build (that requires the includeAbsolute to be false), which also successfully compiles and loads in the browser where it previously gave a TypeError on loading some assets that weren't JavaScript files.

If I need to change anything to comply with the standards in this repo, please drop a comment and I'll happily oblige. Please let me know what I can do.

ygj6 commented 2 years ago

LGTM. And we have the same problem.

ygj6 commented 2 years ago

@sodatea @patak-dev , could you take time to review this PR? thanks!