worker.rollupOptions.output does not control output directory bug has returned in v5.2.0

mdaemon-technologies commented 3 months ago

Describe the bug

Specifying assetFileNamesand chunkFileNamesin worker.rollupOptions does not affect the worker's output directory.

I tested using the same stackblitz for v3, v4, v5. It does not appear to have ever been fixed, even though I found multiple closed duplicates.

Is there an additional library required?

Reproduction

https://stackblitz.com/edit/vitejs-vite-8bjpzf

Steps to reproduce

open the reproduction link
run npm run build

System Info

https://stackblitz.com/edit/vitejs-vite-8bjpzf

Used Package Manager

npm

Logs

vite.config.js
import { defineConfig } from 'vite';

export default defineConfig(({ command, mode }) => {
  return {
    worker: {
      rollupOptions: {
        output: {
          assetFileNames: 'worker/asset/[name].js',
          chunkFileNames: 'worker/chunk/[name].js',
        },
      },
    },
  };
});

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

stackblitz[bot] commented 3 months ago

Start a new pull request in StackBlitz Codeflow.

vitejs-vite-8bjpzf (Open reproduction)

sapphi-red commented 3 months ago

You need to set worker.rollupOptions.output.entryFileNames. https://stackblitz.com/edit/vitejs-vite-1irzjy?file=vite.config.js

mdaemon-technologies commented 3 months ago

That did work in the minimal reproduction. However, in my local build of 5.2.0 it did not work. What did work was moving the "worker" property above the "build" property in the vite.config.js file. Clearly, the location of the property should not matter.

before:

build: {
  rollupOptions: {
    output: {
      assetFileNames: "web/assets/[name]-[hash].[ext]",
      chunkFileNames: "web/assets/[name]-[hash].[ext]",
      entryFileNames: "web/assets/[name]-[hash].js"
    }
  }
},
worker: {
  format: "es",
  rollupOptions: {
    output: {
      entryFileNames: `web/workers/[name]-[hash].js`,
    }
  }
},

output:

dist/assets/myworker-dxgnPMyq.js

after

worker: {
  format: "es",
  rollupOptions: {
    output: {
      entryFileNames: `web/workers/[name]-[hash].js`,
    }
  }
},
build: {
  rollupOptions: {
    output: {
      assetFileNames: "web/assets/[name]-[hash].[ext]",
      chunkFileNames: "web/assets/[name]-[hash].[ext]",
      entryFileNames: "web/assets/[name]-[hash].js"
    }
  }
},

output:

dist/web/workers/myworker-rgRqI9cd.js

vitejs / vite