Vite injects __vitePreload even if the modulePreload option is disabled

lubomirblazekcz commented 3 weeks ago

Describe the bug

Vite injects __vitePreload on each dynamic import, I would expected this not be included when modulePreload is set to false.

Eg. If I want to handle preloading manually or not at all.

Reproduction

https://stackblitz.com/edit/vitejs-vite-p54vgg

Steps to reproduce

Run vite build and the output is actually larger then the source.

System Info

..

Used Package Manager

npm

Logs

No response

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

bluwy commented 3 weeks ago

vritant24 commented 3 days ago

In our scenario, preloading any file causes errors as we have a tricky way of resolving file paths (our code runs inside a vscode controlled iframe). Specifically __vitePreload injects a stylesheet link that causes our page to not load.

Following the referenced PRs and issues, I understand why it's the case, but is there a workaround to prevent the runtime injection of the preloads today?

vitejs / vite