search

vitejs / vite

Next generation frontend tooling. It's fast!
http://vite.dev
MIT License
68.73k stars 6.21k forks source link

test: remove `runInBuild` flag from `withRetry` #18698

Closed hi-ogawa closed 3 days ago

hi-ogawa commented 4 days ago

Description

withRetry gets me confused from time to time as it skips assertions on build by default. From the current usage, I couldn't tell the benefit of this behavior, so I replaced it with adding runIf(isServe) at dev only tests.

hi-ogawa commented 4 days ago

Hmm, I remembered untilUpdated also has runInBuild flag. Probably it was on https://github.com/vitejs/vite-plugin-react where I was surprised by this behavior as it uses the same test helpers.

If people agree withRetry should be fixed as in this PR, then I can also update untilUpdated too.