Supress Vite import() warnings when https:// modules are used

lubomirblazekcz commented 3 years ago

Describe the bug

7  |      const lang = await import(`https://cdn.esm.sh/v41/vanillajs-datepicker/locales/${document.documentElement.lang === "en" ? "cs" : document.documentElement.lang}.js`);
   |                                ^
8  |  
9  |      console.log(lang.default);
The above dynamic import cannot be analyzed by vite.
See https://github.com/rollup/plugins/tree/master/packages/dynamic-import-vars#limitations for supported dynamic import formats. If this is intended to be left as-is, you can use the /* @vite-ignore */ comment inside the import() call to suppress this warning.

Reproduction

(async() => {
    const lang = await import(`https://cdn.esm.sh/v41/vanillajs-datepicker/locales/${document.documentElement.lang === "en" ? "cs" : document.documentElement.lang}.js`);

    console.log(lang.default);
})()

Before submitting the issue, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the docs.
[x] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[x] Provide a description in this issue that describes the bug.
[x] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[x] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.

lubomirblazekcz commented 3 years ago

Also sort of related to https://github.com/vitejs/vite/issues/2483 when importmaps or es-module-shims are used __vite__injectQuery causes problems here.

Vite should ignore https:// and imports that are handled by importmaps and don't do any modifications to it.

bluwy commented 2 years ago

You can suppress the warning with:

const lang = await import(/* @vite-ignore */ `https://cdn.esm.sh/v41/vanillajs-datepicker/locales/${document.documentElement.lang === "en" ? "cs" : document.documentElement.lang}.js`);

as suggested in the warning message.

Vite does a simple regex pass to try to capture the import string, so it can't know that the import string starts with http in the first place to be skipping it. The warning message is emitted when the regex fails.

vitejs / vite