Open antfu opened 2 years ago
I can confirm this too. I had always assumed this to be intentional since prebundling is always necessary for third-party libraries. Or it would cause the duplication issue as mentioned. Is there a reason to exclude vue-demi
? (I'm not familiar with the current state of Nuxt)
Some packages might be relying on the internal singleton states (in my case is @vue/composition-api
). Just imagining
import Vue from 'vue'
Vue.use(SomePlugin)
import Vue from 'vue'
Vue.$someplugin() // if the `vue` is not the same vue, it will failed.
So I guess at least we should support something like: (similar to the include pattern https://vitejs.dev/config/#optimizedeps-exclude)
optimizeDeps: {
exclude: [
'* > vue-demi'
]
}
We also had the same singleton issue for Svelte as well. The solution was to force optimizeDeps.include
on svelte
, so the prebundled code essentially deduped it. I think the code example can be fixed the same way as well by adding vue
to optimizeDeps.include
. I'm not entirely clear why vue-demi
is to be excluded :sweat_smile: but the exclude pattern is certainly a nice addition where needed.
Yeah, the problem is that we want to do some aliasing here so we have to opt-out of those dependencies. If we exclude one sub dependencies (vue-demi) which make all packages on top of it also be excluded from the optimization (otherwise it would still have duplications). From Nuxt's perspective, it's impossible to list all the packages relying on vue-demi
or @vue/composition-api
to exclude them out. Not only the performance might suffer for unbundled packages, it also means any new packages that are not on the exclusion list will break the app 😅
I will see what I can improve it and drop a PR soon
Yeah, the problem is that we want to do some aliasing here so we have to opt-out of those dependencies. If we exclude one sub dependencies (vue-demi) which make all packages on top of it also be excluded from the optimization (otherwise it would still have duplications). From Nuxt's perspective, it's impossible to list all the packages relying on
vue-demi
or@vue/composition-api
to exclude them out. Not only the performance might suffer for unbundled packages, it also means any new packages that are not on the exclusion list will break the app 😅I will see what I can improve it and drop a PR soon
Hey @antfu Loved your talk 2 days ago :) But I'm also looking intro upgrading to nuxt 3.2 but I now also face the same issue.
SyntaxError: The requested module 'vue-demi' does not provide an export named 'default'
It's from a package which has vue-demi as a nested dependency.
Describe the bug
For example, we have
@vueuse/core
relying onvue-demi
, if we exclude the optimization forvue-demi
(but not@vueuse/core
) viaWhich the nested
vue-demi
does not been excluded from the optimized bundle for@vueuse/core
. Causing the potential duplication for deps.Related nuxt/bridge#186
Reproduction
(Just creating a quick issue for tracking, will fulfill the repro and make the PR soon)
System Info
Used Package Manager
pnpm
Logs
No response
Validations