Link to stylesheet is transformed to javascript import

trygveaa commented 1 year ago

Describe the bug

I'm trying to include an external css file in my html, but vite transforms it to an import from the javascript bundle, so I get this error: Failed to load module script: Expected a JavaScript module script but the server responded with a MIME type of "text/css". Strict MIME type checking is enforced for module scripts per HTML spec.

I have this line in index.html:

<link rel="stylesheet" href="/css/style.css?family=Splash" />

In production, the css is available in that location and for development I have included a proxy rule for it, so I would like the line to stay like that in the built html file. When I run npm run dev this is what happens and it works. However when I run npm run build it removes this line, and instead includes it as an import from the javascript bundle. Since this is a css file, not a javascript file, that fails when the browser tries to load it.

Steps to reproduce

Clone the repo.
Run npm i and npm run build && npm run preview.
Open http://localhost:3000/ in a browser and observe the error.

If you wonder why I have a rewrite rule to remove style.css, this is just because the public font I include in the example is only available on /css and the issue only seem to happen if what I include has a .css extension. In my real world use case, the file is actually called style.css, so then the issue happens without any rewrite rule.

Reproduction

https://github.com/trygveaa/vite-external-stylesheet-bug

System Info

System:
    OS: Linux 5.18 Arch Linux
    CPU: (8) x64 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
    Memory: 13.64 GB / 31.08 GB
    Container: Yes
    Shell: 5.9 - /usr/bin/zsh
  Binaries:
    Node: 16.15.1 - /usr/bin/node
    Yarn: 1.22.19 - /usr/bin/yarn
    npm: 8.5.5 - /usr/bin/npm
  Browsers:
    Chromium: 102.0.5005.115
    Firefox: 101.0.1

Used Package Manager

npm

Logs

No response

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

bluwy commented 1 year ago

I can't seem to find the issue, but I remember suggesting supporting  for something like this. Another way is to ignore this if specified in build.rollupOptions.external (but that sounds a bit unconventional)

trygveaa commented 1 year ago

Not sure I understand why I would have to specify that it shouldn't be transformed. When does it make sense for vite to transform a link to a css file to a javascript import?

bluwy commented 1 year ago

It's transformed to an import as Vite sees that it could be resolved to something else. See

https://github.com/vitejs/vite/blob/ce790c4080b6592ed60edfcf90a9ec344d575fa1/packages/vite/src/node/plugins/html.ts#L356-L359 and https://github.com/vitejs/vite/blob/ce790c4080b6592ed60edfcf90a9ec344d575fa1/packages/vite/src/node/plugins/html.ts#L227-L231

Perhaps something Vite could do is try to resolve the CSS before deciding to transform to an import. That way we don't need  🤔

trygveaa commented 1 year ago

But it's listed in rollupOptions/externals so it will never be resolved to something else? Is the issue that the import is created regardless of this option since it's a rollup option?