search

vitejs / vite

Next generation frontend tooling. It's fast!
http://vitejs.dev
MIT License
67.15k stars 6.04k forks source link

cant resolve css in deep node_module dir #9681

Open xiaoosi opened 2 years ago

xiaoosi commented 2 years ago

Describe the bug

I import a less file in src. this less file import B.less in node_module, B.less import A.less in moduleB own node_module. vite cant find A.less

Reproduction

https://github.com/xiaoosi/vite-css-test/blob/master/node_modules/testMoB/B.less

System Info

System:
    OS: macOS 12.2.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 282.52 MB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 18.4.0 - ~/.nvm/versions/node/v18.4.0/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 8.12.1 - ~/.nvm/versions/node/v18.4.0/bin/npm
  Browsers:
    Chrome: 104.0.5112.79
    Safari: 15.3
  npmPackages:
    @vitejs/plugin-react: ^2.0.1 => 2.0.1 
    vite: ^3.0.7 => 3.0.7

Used Package Manager

pnpm

Logs

// pnpm run dev
vite:config bundled config file loaded in 143.36ms +0ms
  vite:config using resolved config: {
  vite:config   plugins: [
  vite:config     'vite:pre-alias',
  vite:config     'alias',
  vite:config     'vite:react-babel',
  vite:config     'vite:react-refresh',
  vite:config     'vite:react-jsx',
  vite:config     'vite:modulepreload-polyfill',
  vite:config     'vite:optimized-deps',
  vite:config     'vite:resolve',
  vite:config     'vite:html-inline-proxy',
  vite:config     'vite:css',
  vite:config     'vite:esbuild',
  vite:config     'vite:json',
  vite:config     'vite:wasm-helper',
  vite:config     'vite:worker',
  vite:config     'vite:asset',
  vite:config     'vite:wasm-fallback',
  vite:config     'vite:define',
  vite:config     'vite:css-post',
  vite:config     'vite:worker-import-meta-url',
  vite:config     'vite:dynamic-import-vars',
  vite:config     'vite:import-glob',
  vite:config     'vite:client-inject',
  vite:config     'vite:import-analysis'
  vite:config   ],
  vite:config   css: { preprocessorOptions: { less: {} } },
  vite:config   optimizeDeps: {
  vite:config     disabled: 'build',
  vite:config     force: undefined,
  vite:config     include: [ 'react/jsx-runtime', 'react/jsx-dev-runtime' ],
  vite:config     esbuildOptions: { preserveSymlinks: undefined }
  vite:config   },
  vite:config   server: {
  vite:config     preTransformRequests: true,
  vite:config     middlewareMode: false,
  vite:config     fs: { strict: true, allow: [Array], deny: [Array] }
  vite:config   },
  vite:config   resolve: { dedupe: [ 'react', 'react-dom' ], alias: [ [Object], [Object] ] },
  vite:config   configFile: '/Users/bytedance/work/vite/react-app/vite.config.ts',
  vite:config   configFileDependencies: [ '/Users/bytedance/work/vite/react-app/vite.config.ts' ],
  vite:config   inlineConfig: {
  vite:config     root: undefined,
  vite:config     base: undefined,
  vite:config     mode: undefined,
  vite:config     configFile: undefined,
  vite:config     logLevel: undefined,
  vite:config     clearScreen: undefined,
  vite:config     optimizeDeps: { force: undefined },
  vite:config     server: {}
  vite:config   },
  vite:config   root: '/Users/bytedance/work/vite/react-app',
  vite:config   base: '/',
  vite:config   publicDir: '/Users/bytedance/work/vite/react-app/public',
  vite:config   cacheDir: '/Users/bytedance/work/vite/react-app/node_modules/.vite',
  vite:config   command: 'serve',
  vite:config   mode: 'development',
  vite:config   ssr: {
  vite:config     format: 'esm',
  vite:config     target: 'node',
  vite:config     optimizeDeps: { disabled: true, esbuildOptions: [Object] }
  vite:config   },
  vite:config   isWorker: false,
  vite:config   mainConfig: null,
  vite:config   isProduction: false,
  vite:config   build: {
  vite:config     target: [ 'es2020', 'edge88', 'firefox78', 'chrome87', 'safari13' ],
  vite:config     polyfillModulePreload: true,
  vite:config     outDir: 'dist',
  vite:config     assetsDir: 'assets',
  vite:config     assetsInlineLimit: 4096,
  vite:config     cssCodeSplit: true,
  vite:config     cssTarget: [ 'es2020', 'edge88', 'firefox78', 'chrome87', 'safari13' ],
  vite:config     sourcemap: false,
  vite:config     rollupOptions: {},
  vite:config     minify: 'esbuild',
  vite:config     terserOptions: {},
  vite:config     write: true,
  vite:config     emptyOutDir: null,
  vite:config     manifest: false,
  vite:config     lib: false,
  vite:config     ssr: false,
  vite:config     ssrManifest: false,
  vite:config     reportCompressedSize: true,
  vite:config     chunkSizeWarningLimit: 500,
  vite:config     watch: null,
  vite:config     commonjsOptions: { include: [Array], extensions: [Array] },
  vite:config     dynamicImportVarsOptions: { warnOnError: true, exclude: [Array] }
  vite:config   },
  vite:config   preview: {
  vite:config     port: undefined,
  vite:config     strictPort: undefined,
  vite:config     host: undefined,
  vite:config     https: undefined,
  vite:config     open: undefined,
  vite:config     proxy: undefined,
  vite:config     cors: undefined,
  vite:config     headers: undefined
  vite:config   },
  vite:config   env: { BASE_URL: '/', MODE: 'development', DEV: true, PROD: false },
  vite:config   assetsInclude: [Function: assetsInclude],
  vite:config   logger: {
  vite:config     hasWarned: false,
  vite:config     info: [Function: info],
  vite:config     warn: [Function: warn],
  vite:config     warnOnce: [Function: warnOnce],
  vite:config     error: [Function: error],
  vite:config     clearScreen: [Function: clearScreen],
  vite:config     hasErrorLogged: [Function: hasErrorLogged]
  vite:config   },
  vite:config   packageCache: Map(0) {},
  vite:config   createResolver: [Function: createResolver],
  vite:config   worker: {
  vite:config     format: 'iife',
  vite:config     plugins: [
  vite:config       'vite:pre-alias',
  vite:config       'alias',
  vite:config       'vite:modulepreload-polyfill',
  vite:config       'vite:optimized-deps',
  vite:config       'vite:resolve',
  vite:config       'vite:html-inline-proxy',
  vite:config       'vite:css',
  vite:config       'vite:esbuild',
  vite:config       'vite:json',
  vite:config       'vite:wasm-helper',
  vite:config       'vite:worker',
  vite:config       'vite:asset',
  vite:config       'vite:wasm-fallback',
  vite:config       'vite:define',
  vite:config       'vite:css-post',
  vite:config       'vite:worker-import-meta-url',
  vite:config       'vite:dynamic-import-vars',
  vite:config       'vite:import-glob',
  vite:config       'vite:client-inject',
  vite:config       'vite:import-analysis'
  vite:config     ],
  vite:config     rollupOptions: {}
  vite:config   },
  vite:config   appType: 'spa',
  vite:config   experimental: { importGlobRestoreExtension: false, hmrPartialAccept: false }
  vite:config } +4ms
  vite:deps Hash is consistent. Skipping. Use --force to override. +0ms

  VITE v3.0.7  ready in 226 ms

  ➜  Local:   http://localhost:5173/
  ➜  Network: use --host to expose
  vite:spa-fallback Rewriting GET / to /index.html +0ms
  vite:time 14.99ms /index.html +0ms
  vite:spa-fallback Rewriting GET / to /index.html +22ms
  vite:time 2.09ms /index.html +11ms
  vite:resolve 1.59ms /@vite/client -> /Users/bytedance/work/vite/react-app/node_modules/.pnpm/vite@3.0.7_less@4.1.3/node_modules/vite/dist/client/client.mjs +0ms
  vite:resolve 0.14ms /src/main.tsx -> /Users/bytedance/work/vite/react-app/src/main.tsx +3ms
  vite:load 1.10ms [fs] /src/main.tsx +0ms
  vite:load 53.62ms [fs] /@vite/client +50ms
  vite:load 0.01ms [plugin] /@react-refresh +2ms
  vite:import-analysis 0.32ms [no imports] /@react-refresh +0ms
  vite:transform 2.77ms /@react-refresh +0ms
  vite:time 3.07ms /@react-refresh +79ms
  vite:resolve 0.38ms @vite/env -> /Users/bytedance/work/vite/react-app/node_modules/.pnpm/vite@3.0.7_less@4.1.3/node_modules/vite/dist/client/env.mjs +59ms
  vite:resolve 0.11ms /node_modules/.pnpm/vite@3.0.7_less@4.1.3/node_modules/vite/dist/client/env.mjs -> /Users/bytedance/work/vite/react-app/node_modules/.pnpm/vite@3.0.7_less@4.1.3/node_modules/vite/dist/client/env.mjs +0ms
  vite:import-analysis 2.48ms [1 imports rewritten] node_modules/.pnpm/vite@3.0.7_less@4.1.3/node_modules/vite/dist/client/client.mjs +3ms
  vite:transform 7.04ms /@vite/client +3ms
  vite:time 65.18ms /@vite/client +3ms
  vite:load 1.28ms [fs] /node_modules/.pnpm/vite@3.0.7_less@4.1.3/node_modules/vite/dist/client/env.mjs +8ms
  vite:import-analysis 0.02ms [no imports] node_modules/.pnpm/vite@3.0.7_less@4.1.3/node_modules/vite/dist/client/env.mjs +3ms
  vite:transform 1.14ms /node_modules/.pnpm/vite@3.0.7_less@4.1.3/node_modules/vite/dist/client/env.mjs +3ms
  vite:resolve 0.26ms react -> /Users/bytedance/work/vite/react-app/node_modules/.vite/deps/react.js?v=730ee73c +6ms
  vite:resolve 0.03ms /node_modules/.vite/deps/react.js?v=730ee73c -> /Users/bytedance/work/vite/react-app/node_modules/.vite/deps/react.js?v=730ee73c +0ms
  vite:import-analysis /node_modules/.vite/deps/react.js?v=730ee73c needs interop +3ms
  vite:resolve 0.06ms react-dom/client -> /Users/bytedance/work/vite/react-app/node_modules/.vite/deps/react-dom_client.js?v=730ee73c +2ms
  vite:resolve 0.03ms /node_modules/.vite/deps/react-dom_client.js?v=730ee73c -> /Users/bytedance/work/vite/react-app/node_modules/.vite/deps/react-dom_client.js?v=730ee73c +0ms
  vite:import-analysis /node_modules/.vite/deps/react-dom_client.js?v=730ee73c needs interop +2ms
  vite:resolve 0.32ms ./App -> /Users/bytedance/work/vite/react-app/src/App.tsx +1ms
  vite:resolve 0.05ms /src/App.tsx -> /Users/bytedance/work/vite/react-app/src/App.tsx +0ms
  vite:resolve 0.05ms ./index.css -> /Users/bytedance/work/vite/react-app/src/index.css +1ms
  vite:resolve 0.04ms /src/index.css -> /Users/bytedance/work/vite/react-app/src/index.css +0ms
  vite:resolve 0.01ms react/jsx-dev-runtime -> react/jsx-dev-runtime +0ms
  vite:resolve 0.18ms /@id/__x00__react/jsx-dev-runtime -> null +0ms
  vite:import-analysis 4.91ms [5 imports rewritten] src/main.tsx +1ms
  vite:transform 69.10ms /src/main.tsx +8ms
  vite:resolve 2.29ms react/jsx-dev-runtime -> null +3ms
  vite:optimize-deps load /Users/bytedance/work/vite/react-app/node_modules/.vite/deps/react.js +0ms
  vite:optimize-deps load /Users/bytedance/work/vite/react-app/node_modules/.vite/deps/react-dom_client.js +0ms
  vite:load 0.01ms [plugin] react/jsx-dev-runtime +10ms
  vite:resolve 0.04ms react/jsx-dev-runtime -> /Users/bytedance/work/vite/react-app/node_modules/.vite/deps/react_jsx-dev-runtime.js?v=730ee73c +1ms
  vite:resolve 0.02ms /node_modules/.vite/deps/react_jsx-dev-runtime.js?v=730ee73c -> /Users/bytedance/work/vite/react-app/node_modules/.vite/deps/react_jsx-dev-runtime.js?v=730ee73c +0ms
  vite:import-analysis /node_modules/.vite/deps/react_jsx-dev-runtime.js?v=730ee73c needs interop +4ms
  vite:import-analysis 0.66ms [1 imports rewritten] react/jsx-dev-runtime +0ms
  vite:transform 0.73ms react/jsx-dev-runtime +2ms
  vite:optimize-deps load /Users/bytedance/work/vite/react-app/node_modules/.vite/deps/react_jsx-dev-runtime.js +1ms
  vite:cache [304] /node_modules/.pnpm/vite@3.0.7_less@4.1.3/node_modules/vite/dist/client/env.mjs +0ms
  vite:time 0.25ms /node_modules/.pnpm/vite@3.0.7_less@4.1.3/node_modules/vite/dist/client/env.mjs +14ms
  vite:load 2.30ms [plugin] /node_modules/.vite/deps/react.js?v=730ee73c +2ms
  vite:resolve 0.35ms ./chunk-5GQ5M67L.js -> /Users/bytedance/work/vite/react-app/node_modules/.vite/deps/chunk-5GQ5M67L.js?v=730ee73c +2ms
  vite:resolve 0.03ms /node_modules/.vite/deps/chunk-5GQ5M67L.js?v=730ee73c -> /Users/bytedance/work/vite/react-app/node_modules/.vite/deps/chunk-5GQ5M67L.js?v=730ee73c +0ms
  vite:import-analysis 0.84ms [1 imports rewritten] node_modules/.vite/deps/react.js?v=730ee73c +3ms
  vite:transform 1.30ms /node_modules/.vite/deps/react.js?v=730ee73c +3ms
  vite:optimize-deps load /Users/bytedance/work/vite/react-app/node_modules/.vite/deps/chunk-5GQ5M67L.js +3ms
  vite:load 3.84ms [fs] /src/App.tsx +2ms
  vite:load 19.28ms [plugin] /node_modules/.vite/deps/react_jsx-dev-runtime.js?v=730ee73c +17ms
  vite:import-analysis 0.75ms [1 imports rewritten] node_modules/.vite/deps/react_jsx-dev-runtime.js?v=730ee73c +18ms
  vite:transform 1.07ms /node_modules/.vite/deps/react_jsx-dev-runtime.js?v=730ee73c +18ms
  vite:time 94.57ms /src/main.tsx +20ms
  vite:load 23.61ms [fs] /src/index.css +3ms
  vite:load 26.36ms [plugin] /node_modules/.vite/deps/react-dom_client.js?v=730ee73c +2ms
  vite:import-analysis 11.44ms [1 imports rewritten] node_modules/.vite/deps/react-dom_client.js?v=730ee73c +20ms
  vite:transform 15.40ms /node_modules/.vite/deps/react-dom_client.js?v=730ee73c +20ms
  vite:import-analysis /node_modules/.vite/deps/react.js?v=730ee73c needs interop +3ms
  vite:resolve 0.11ms ./assets/react.svg -> /Users/bytedance/work/vite/react-app/src/assets/react.svg +42ms
  vite:resolve 0.05ms /src/assets/react.svg -> /Users/bytedance/work/vite/react-app/src/assets/react.svg +0ms
  vite:resolve 0.04ms ./App.css -> /Users/bytedance/work/vite/react-app/src/App.css +0ms
  vite:resolve 0.04ms /src/App.css -> /Users/bytedance/work/vite/react-app/src/App.css +1ms
  vite:resolve 0.04ms ./style/index.less -> /Users/bytedance/work/vite/react-app/src/style/index.less +0ms
  vite:resolve 0.04ms /src/style/index.less -> /Users/bytedance/work/vite/react-app/src/style/index.less +0ms
  vite:hmr [self-accepts] src/App.tsx +0ms
  vite:import-analysis 1.74ms [6 imports rewritten] src/App.tsx +1ms
  vite:transform 43.06ms /src/App.tsx +5ms
  vite:cache [memory] /@react-refresh +0ms
  vite:cache [memory] /node_modules/.vite/deps/react.js?v=730ee73c +0ms
  vite:cache [memory] react/jsx-dev-runtime +0ms
  vite:load 0.15ms [plugin] /src/assets/react.svg +21ms
  vite:import-analysis 0.00ms [no imports] src/assets/react.svg +2ms
  vite:transform 0.07ms /src/assets/react.svg +1ms
  vite:load 44.13ms [plugin] /node_modules/.vite/deps/chunk-5GQ5M67L.js?v=730ee73c +1ms
  vite:import-analysis 0.41ms [no imports] node_modules/.vite/deps/chunk-5GQ5M67L.js?v=730ee73c +1ms
  vite:transform 0.79ms /node_modules/.vite/deps/chunk-5GQ5M67L.js?v=730ee73c +1ms
  vite:cache [memory] /node_modules/.vite/deps/react.js?v=730ee73c +2ms
  vite:time 0.39ms /node_modules/.vite/deps/react.js?v=730ee73c +27ms
  vite:cache [memory] /node_modules/.vite/deps/react-dom_client.js?v=730ee73c +1ms
  vite:time 0.11ms /node_modules/.vite/deps/react-dom_client.js?v=730ee73c +1ms
  vite:load 6.50ms [fs] /src/style/index.less +6ms
  vite:load 6.95ms [fs] /src/App.css +0ms
  vite:time 3.41ms /src/App.tsx +6ms
  vite:hmr [self-accepts] src/index.css +14ms
  vite:import-analysis 0.14ms [0 imports rewritten] src/index.css +11ms
  vite:transform 36.37ms /src/index.css +11ms
  vite:time 5.55ms /src/index.css +5ms
  vite:resolve 0.97ms testMoB/B.less -> /Users/bytedance/work/vite/react-app/node_modules/testMoB/B.less +0ms
  vite:resolve 0.29ms testMoA/A.less -> null +2ms
  vite:hmr [self-accepts] src/App.css +69ms
  vite:import-analysis 0.08ms [0 imports rewritten] src/App.css +69ms
  vite:transform 74.42ms /src/App.css +69ms
  vite:cache [memory] react/jsx-dev-runtime +79ms
  vite:time 0.22ms /@id/__x00__react/jsx-dev-runtime +68ms
  vite:cache [memory] /node_modules/.vite/deps/chunk-5GQ5M67L.js?v=730ee73c +1ms
  vite:time 0.24ms /node_modules/.vite/deps/chunk-5GQ5M67L.js?v=730ee73c +1ms
  vite:cache [304] /src/assets/react.svg +128ms
  vite:time 0.13ms /src/assets/react.svg?import +0ms
'testMoA/A.less' wasn't found. Tried - /Users/bytedance/work/vite/react-app/node_modules/testMoB/testMoA/A.less,node_modules/testMoA/A.less,npm://testMoA/A.less,testMoA/A.less
  vite:cache [304] /src/App.css +6ms
  vite:time 0.32ms /src/App.css +6ms
  vite:load 0.93ms [fs] /src/style/index.less +84ms
  vite:cache [memory] /node_modules/.vite/deps/react_jsx-dev-runtime.js?v=730ee73c +10ms
  vite:time 0.23ms /node_modules/.vite/deps/react_jsx-dev-runtime.js?v=730ee73c +4ms
21:27:56 [vite] Internal server error: 'testMoA/A.less' wasn't found. Tried - /Users/bytedance/work/vite/react-app/node_modules/testMoB/testMoA/A.less,node_modules/testMoA/A.less,npm://testMoA/A.less,testMoA/A.less
  Plugin: vite:css
  File: /Users/bytedance/work/vite/react-app/node_modules/testMoB/B.less
  1  |  @import "testMoA/A.less";
     |  ^
  2  |  
  3  |  * {
      at less (file:///Users/bytedance/work/vite/react-app/node_modules/.pnpm/vite@3.0.7_less@4.1.3/node_modules/vite/dist/node/chunks/dep-0f13c890.js:42830:33)
      at async compileCSS (file:///Users/bytedance/work/vite/react-app/node_modules/.pnpm/vite@3.0.7_less@4.1.3/node_modules/vite/dist/node/chunks/dep-0f13c890.js:42268:34)
      at async TransformContext.transform (file:///Users/bytedance/work/vite/react-app/node_modules/.pnpm/vite@3.0.7_less@4.1.3/node_modules/vite/dist/node/chunks/dep-0f13c890.js:41852:55)
      at async Object.transform (file:///Users/bytedance/work/vite/react-app/node_modules/.pnpm/vite@3.0.7_less@4.1.3/node_modules/vite/dist/node/chunks/dep-0f13c890.js:35293:30)
      at async loadAndTransform (file:///Users/bytedance/work/vite/react-app/node_modules/.pnpm/vite@3.0.7_less@4.1.3/node_modules/vite/dist/node/chunks/dep-0f13c890.js:39879:29)
  vite:time 14.68ms /src/style/index.less +12ms
  vite:time 0.47ms /vite.svg +60ms
  vite:deps ✨ static imports crawl ended +609ms

Validations

sapphi-red commented 2 years ago

related: #7802

xiaoosi commented 2 years ago

related: #7802

I think vite should import A.less from ./node_module/testMoB/node_module/testMoA/A.less but not import from ./node_module/testMoA/A.less.

I only used testMoB and should not care about testMoA's version. The version of testMoA should be specified by testMoB.

john-w-cole commented 1 year ago

Has anyone made progress on this issue? I'm running into a similar issue with SCSS files and the additionalData is not working for .vue files imported from a npm package.

mkilpatrick commented 7 months ago

Does merged fix above address this issue too?

Guebbit commented 6 months ago

Hello, I have a very similar problem.

I have 2 CSS repo built with Vite: A and B. B need A, so it's on the package.json under "dependencies" (the only one).

When I install B on another project, node_modules (and so A) it's missing so B doesn't work.
I don't understand. Shouldn't the package.json be enough?

P.S: They are both pure css libraries. The only js file it's the vite.config.js No error are shown during install or build. The node_modules file it's simply missing.