vitelabs / vite-wallet

The Desktop Wallet of Vite
http://vite.org/
37 stars 14 forks source link

Add coala for linting and fixing code #1

Closed srisankethu closed 6 years ago

srisankethu commented 6 years ago

Instead of downloading language specific linters, we can use coala for linting and fixing for all languages. If my issue is accepted, I can set up a .coafile for every repo where it is needed(please specific in which repos do you need it). In a new issue, i will fix the linting errors is any arise.

Label: enhancement

I can here via the Vite developer initiative plan announced on Vite Announcement(Telegram). ETH address: 0x08ac6d7ce02e7CFa050eECa4aFF73B862B6889bB

osdio commented 6 years ago

Is there any advantage of using coala? I think in front-end using eslint is enough. Can you explain why coala is better than eslint in front-end?

srisankethu commented 6 years ago

coala provides a multi-language support. It basically uses the features of different linters available. On the front-end using eslint is enough I guess. But for multi-language support and testing purposes, it is useful. We can add it to projects where there are for example .md, .js, .json, .go, .vue files.

osdio commented 6 years ago

Through consideration, we think eslint is better for this project because this project is only a front-end project(vite-wallet). Eslint have the better support of Vue and Jsx. Anyway, thank you very much.

srisankethu commented 6 years ago

@soliury coala uses ESLINT. It gives a multi-linter support too for JS. Its not that coala does not use ESLINT(if that what you are thinking I assume).

I have just noticed https://github.com/vitelabs/vite-explorer-server and https://github.com/vitelabs/go-vite do not have linters for Go Lang.

AllenLiuxt commented 6 years ago

Thanks for the advice. The team believes at this stage eslint fits our web projects well and we don't want to introduce more complexity by involving more linters. As for golang linter you mentioned the built-in tools provided by the IDE and the language itself is sufficient as well.

srisankethu commented 6 years ago

@AllenLiuxt :+1: