search

vitessce / vitessce-python

Python API and Jupyter widget for Vitessce
https://python-docs.vitessce.io
MIT License
38 stars 7 forks source link

(feat): `SpatialData` wrapper #333

Open ilan-gold opened 5 months ago

ilan-gold commented 5 months ago

This is a first pass at a SpatialData wrapper.

Complete #331 for SpatialData via a static method (my preferred solution for 331).

Some todos:

LucaMarconato commented 4 months ago

@ilan-gold could you please try installing from this PR? https://github.com/scverse/spatialdata/pull/545

ilan-gold commented 4 months ago

New problem @LucaMarconato :( https://github.com/vitessce/vitessce-python/actions/runs/9250228613/job/25443383983?pr=333

Old one is fixed though! Thanks!

LucaMarconato commented 3 months ago

I think this could get fixed after https://github.com/scverse/spatialdata/pull/570 is ready (it should be ready in 1-2 days).

ilan-gold commented 3 months ago

thanks a bunch @LucaMarconato !

LucaMarconato commented 3 months ago

The PR is now ready for review. Can you please check if it fixes the issues in this PR @ilan-gold?

LucaMarconato commented 3 months ago

I made some recent commits in the last hour; unless you tried one of those commits that didn't make the CI status green (now it's green again), it seems that the bug remains. Could you please isolate a short code snippet to reproduce this bug? I can have a look at it later (the error message in the CI is something I haven't encountered so far).

ilan-gold commented 3 months ago

@LucaMarconato just needed to cache bust i guess. fixed now!

LucaMarconato commented 3 months ago

Ah ok great to hear! I had also tagged you here, which should explain the source of the problem: https://github.com/scverse/spatialdata/pull/615.

ilan-gold commented 1 month ago

@keller-mark Fixing notebook, apologies

ilan-gold commented 1 week ago

@keller-mark The only thing happening here is the obsSets is not appearing in the component. Also, selections only kind of working, generating a set, but not actually rendering the result on the image spots.....if you can't see anything immediately going on I'd be happy to investigate as a bug. Thanks!