vitessio / arewefastyet

Automated Benchmarking System for Vitess
https://benchmark.vitess.io
Apache License 2.0
70 stars 59 forks source link

feat: modernize codebase #514

Closed Maniktherana closed 4 months ago

Maniktherana commented 4 months ago

This pr:

Note: making changes to tailwind.config.ts or adding shadcn components requires a rebuild

Maniktherana commented 4 months ago

Changes so far:

Screenshot 2024-02-19 at 1 37 17 PM
Maniktherana commented 4 months ago

EDIT: this PR probably doesn't break what's described below. main branch and this pr both show the same output as in the after image. This may be due to how data is received in dev builds

This PR also breaks json rendering on the /macrobench/queries/compare route. Root cause is most likely not having access to the json class from ReactJson

before:

Screenshot 2024-02-19 at 2 12 06 PM

after:

Screenshot 2024-02-19 at 2 12 21 PM
Maniktherana commented 4 months ago

On Safari the website does not render well at all. It, almost, only shows white pages when the dark mode is turned on. I would advise you to test the PR on different browsers and see how they behave.

This has been fixed, the issue was a typo in tailwind.css

.dark {
-    --background: 0 0% 0;
+    --background: 0 0% 0%;
Maniktherana commented 4 months ago

The page "Daily" causes a few issues. The background of the graphs are not showing up, and the summary cards (when selected) are highlighted with a dark/white color.

graphs are visible now on hovering summary cards

Maniktherana commented 4 months ago

After: image

I've just pushed a potential fix for this but I'm going in blind. I can't see graphs yet on my dev build but the fix involves just using the correct css color variable.

frouioui commented 4 months ago

I've just pushed a potential fix for this but I'm going in blind. I can't see graphs yet on my dev build but the fix involves just using the correct css color variable.

It looks great now:

image