search

vitessio / arewefastyet

Automated Benchmarking System for Vitess
https://benchmark.vitess.io
Apache License 2.0
74 stars 58 forks source link

feat: added shadcn `table` component #528

Closed Gmin2 closed 2 months ago

Gmin2 commented 5 months ago

Added the shadCn table component in DisplayList.tsx

Gmin2 commented 5 months ago

What do you think about modifying the responsive (mobile) version of the table to use shadcn too?

i dont think mobile view will be suited for this page(the shadcn component) as it shrinks and make the text size small it will be difficult to see the data .

image

frouioui commented 5 months ago

i dont think mobile view will be suited for this page(the shadcn component) as it shrinks and make the text size small it will be difficult to see the data

We could however have a card that contains the information we need

Gmin2 commented 4 months ago

We could however have a card that contains the information we need

do we need this @frouioui ?

frouioui commented 4 months ago

@utnim2 I just think that in DisplayList.tsx there is for sure a way of replacing that mobile-only view of the data

frouioui commented 2 months ago

Hello! This change has recently been implemented by @Jad31, i will close this PR for now.