search

vitessio / arewefastyet

Automated Benchmarking System for Vitess
https://benchmark.vitess.io
Apache License 2.0
70 stars 59 forks source link

Adding types in SearchPage #538

Closed DhairyaMajmudar closed 2 months ago

DhairyaMajmudar commented 2 months ago

Search Page files were throwing type errors since the types were not defined which are now resolved by adding relevant types to the files.

Files Changed:

  1. website/src/pages/SearchPage/components/Hero.tsx
  2. website/src/pages/SearchPage/components/SearchMacro.tsx
Gmin2 commented 2 months ago

PR is already there resolving it #529

DhairyaMajmudar commented 2 months ago

PR is already there resolving it #529

Yeah, this PR is more focused on resolving the type errors coming from the props of several data types.

frouioui commented 2 months ago

Thank you for the contribution 🙇🏻

DhairyaMajmudar commented 2 months ago

This looks good to me. Eventually we should do something similar for all functions and props.

I see, will look into this and soon open a PR : )