search

vitessio / arewefastyet

Automated Benchmarking System for Vitess
https://benchmark.vitess.io
Apache License 2.0
70 stars 59 forks source link

Fix: Daily page crash handled #550

Closed mohitvdx closed 3 weeks ago

mohitvdx commented 1 month ago

What kind of change does this PR introduce? Bug fix

Issue Number: fixes #549

Screenshots/videos:

https://github.com/vitessio/arewefastyet/assets/112820522/367ea7b2-a9cc-42e4-aaf8-ce1638124604

Before After
The daily page caused the screen to go blank because dataDaily couldn't be fetched, making it non-iterable and causing a crash. Added error handling to ensure the page loads even if dataDaily cannot be fetched, preventing the site from crashing. The root issue with fetching dataDaily still needs to be resolved.

Does this PR introduce a breaking change? No it doesn't

kindly review @frouioui