vitessio / vitess

Vitess is a database clustering system for horizontal scaling of MySQL.
http://vitess.io
Apache License 2.0
18.23k stars 2.07k forks source link

Feature Request: Support arbitrary ZooKeeper config #13828

Closed adsr closed 10 months ago

adsr commented 11 months ago

Feature Description

Add ability to add arbitrary config lines to ZooKeeper config via zkctl(d)

Use Case(s)

Currently zkctl(d) writes ZK config according to a template in the Vitess repo (zoo.cfg). There is no clean way to customize this config.

For example, we find it useful to add the following configs in our setup:

tcpKeepAlive=true
autopurge.snapRetainCount=10
autopurge.purgeInterval=24

Today we do this by running zkctl init, then modifying the config, then proceeding with other zkctl commands. This feels hacky. Given zkctl is writing the config, it would be nice if zkctl itself supported this.

PR to follow.

adsr commented 10 months ago

Thank you @mattlord & team!