search

vitessio / vitess

Vitess is a database clustering system for horizontal scaling of MySQL.
http://vitess.io
Apache License 2.0
18.18k stars 2.06k forks source link

Improve Unit Test Coverage #14931

Open GuptaManan100 opened 5 months ago

GuptaManan100 commented 5 months ago

Description

The unit test coverage of all the packages in Vitess need to be checked and improved upon. We can look at https://app.codecov.io/gh/vitessio/vitess/tree/main for better guidance on which packages require testing.

List of all the packages in Vitess -

mattlord commented 5 months ago

This is related to: https://github.com/vitessio/vitess/issues/14932

beingnoble03 commented 5 months ago

Can you please assign me vitess/go/acl?

GuptaManan100 commented 5 months ago

@beingnoble03 You can start working on it. When you create a PR, just mention this issue, so that if anyone else looks they know you're working on the said part.

beingnoble03 commented 5 months ago

@GuptaManan100 sure, thanks.

rajivharlalka commented 5 months ago

@GuptaManan100 I was trying to understand the number of LFX mentee's that is proposed to be taken for the upcoming term? Is it just 1 or multiple people would be participating in different parts of the project?

frouioui commented 5 months ago

On https://github.com/vitessio/vitess/pull/14935 we have seen that the coverage of planbuilder is not being reported. On the base branch it is reported as 0.00% which leads to Code coverage failure as soon as we modify the lines in this package and subpackages.

EshaanAgg commented 5 months ago

@GuptaManan100 vitess/go/history already has 100% coverage when I run the tests locally. Can you confirm? image

frouioui commented 5 months ago

@GuptaManan100 vitess/go/history already has 100% coverage when I run the tests locally. Can you confirm?

@EshaanAgg, @GuptaManan100 is OOO, but I can confirm that it already has 100% of coverage on main, see the link below.

https://app.codecov.io/gh/vitessio/vitess/tree/main/go%2Fhistory

verma-kunal commented 5 months ago

Hey folks, I came upon this issue through the LFX Spring project idea page & interested to contribute here! From the issue, I understand that the main task is to add unit tests to various files under the project & improve test coverage (goal is 100%).

I'm a beginner in Go & have familiarity with very basic unit-testing through a personal project. I believe this would be a perfect way to level that up!

It would be a great help if you could point/list a few things out that would help me get me started here, to understand the project a bit more. Thank you

beingnoble03 commented 1 month ago

@GuptaManan100 I've removed go/maps2 and added go/logstats from the PR description as we don't have maps2 anymore, and logstats wasn't listed.