vitessio / vitess

Vitess is a database clustering system for horizontal scaling of MySQL.
http://vitess.io
Apache License 2.0
18.67k stars 2.1k forks source link

[release-20.0] Migrate Workflow: Scope vindex names correctly when target and source keyspace have different names (#16769) #16815

Closed vitess-bot[bot] closed 3 weeks ago

vitess-bot[bot] commented 1 month ago

Description

This is a backport of #16769

vitess-bot[bot] commented 1 month ago

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

Tests

Documentation

New flags

If a workflow is added or modified:

Backward compatibility

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 68.66%. Comparing base (b058ba2) to head (333888d). Report is 17 commits behind head on release-20.0.

Files with missing lines Patch % Lines
go/vt/vtctl/workflow/materializer.go 50.00% 4 Missing :warning:
go/vt/wrangler/materializer.go 50.00% 4 Missing :warning:
go/vt/vtctl/workflow/server.go 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-20.0 #16815 +/- ## ================================================ - Coverage 68.66% 68.66% -0.01% ================================================ Files 1541 1541 Lines 197937 197953 +16 ================================================ Hits 135922 135922 - Misses 62015 62031 +16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 weeks ago

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

If no action is taken within 7 days, this PR will be closed.