MoveTables Create: ensure that none of the tables to be moved have data

vitessio / vitess

Vitess is a database clustering system for horizontal scaling of MySQL.

http://vitess.io

Apache License 2.0

18.47k stars 2.09k forks source link

MoveTables Create: ensure that none of the tables to be moved have data #16817

Open rohit-nayak-ps opened 6 days ago

rohit-nayak-ps commented 6 days ago

Feature Description

When a MoveTables workflow is created, error out if any of the tables (if they exist) have any data.

Use Case(s)

It is possible by mistake to create two workflows for the same set of tables, or select All Tables after some of the tables have been moved. Currently it fails with a duplicate key error after the workflow is created. We should bail out right at Create

mattlord commented 6 days ago

Just FYI: https://github.com/vitessio/vitess/pull/16810/files#diff-1e25101181c9311c90765891b1cea65cc520227bf4d35f3ad0421d1077ea9de5R280-R299

rohit-nayak-ps commented 1 day ago

Incorrectly marked as fixed in #16810

mattlord commented 1 day ago

Incorrectly marked as fixed in #16810

Whoops. Sorry about that. I've updated the description to remove it.