Closed systay closed 1 month ago
Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.
release notes (needs details)
label if users need to know about this change.-
), and have a clear help text.Jobs
should be named in order to mark it as required
.required
, the maintainer team must be notified._vt
tables and RPCs need to be backward compatible.vtctl
command output order should be stable and awk
-able.Attention: Patch coverage is 85.71429%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 69.50%. Comparing base (
538dd4c
) to head (ca83068
). Report is 93 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
go/vt/vtgate/vcursor_impl.go | 83.33% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Is it not incorrect to route these queries to a random shard? If someone runs:
START TRANSACTION; SELECT * FROM `users` WHERE `id` = 1; SELECT NOW(); COMMIT;
Where the users table is sharded on id, one might expect that the
SELECT NOW()
is run on the same machine as theSELECT FROM users
, so that the transaction stays single-shard and so that NOW() returns the time at the start of the transaction, which is how unsharded MySQL works.
Good point. I'll update the PR and try again.
Replaced by #16824
Description
The time zone system setting was not being fetched correctly, which lead to it being ignored when evaluating
now()
.Related Issue(s)
Fixes #16820
Checklist