Closed systay closed 1 month ago
Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.
release notes (needs details)
label if users need to know about this change.-
), and have a clear help text.Jobs
should be named in order to mark it as required
.required
, the maintainer team must be notified._vt
tables and RPCs need to be backward compatible.vtctl
command output order should be stable and awk
-able.All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 69.51%. Comparing base (
95f2e3e
) to head (c4d53fd
). Report is 2 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Updated the description 👍
Description
This pull request addresses a critical issue in the handling of time zone settings within our system. The root cause of the problem was that the time zone system setting was not being correctly fetched and interpreted, which led to it being ignored when evaluating the
now()
function.Specifically, the issue arose because we were storing the time zone variable value using a literal SQL expression. This meant that when we tried to use this value, it was still in its raw, encoded form, rather than being properly decoded into a usable time zone string.
Related Issue(s)
Fixes #16820
Checklist