Closed GuptaManan100 closed 4 days ago
Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.
release notes (needs details)
label if users need to know about this change.-
), and have a clear help text.Jobs
should be named in order to mark it as required
.required
, the maintainer team must be notified._vt
tables and RPCs need to be backward compatible.vtctl
command output order should be stable and awk
-able.All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 69.50%. Comparing base (
490bb0c
) to head (bc8cd61
). Report is 9 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
This PR fixes the error messages check in the test
TestOverallQueryTimeout
. This is a test we introduced recently and noticed that there are actually two possible error messages that can be received based on whether it was vttablet or vtgate that sent it. This PR fixes the test expectations to align with this.Related Issue(s)
Checklist
Deployment Notes