vitessio / vitess

Vitess is a database clustering system for horizontal scaling of MySQL.
http://vitess.io
Apache License 2.0
18.47k stars 2.09k forks source link

Fix error message check on query timeout #16827

Closed GuptaManan100 closed 4 days ago

GuptaManan100 commented 4 days ago

Description

This PR fixes the error messages check in the test TestOverallQueryTimeout. This is a test we introduced recently and noticed that there are actually two possible error messages that can be received based on whether it was vttablet or vtgate that sent it. This PR fixes the test expectations to align with this.

Related Issue(s)

Checklist

Deployment Notes

vitess-bot[bot] commented 4 days ago

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

Tests

Documentation

New flags

If a workflow is added or modified:

Backward compatibility

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.50%. Comparing base (490bb0c) to head (bc8cd61). Report is 9 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #16827 +/- ## ========================================== - Coverage 69.51% 69.50% -0.01% ========================================== Files 1568 1569 +1 Lines 202426 202517 +91 ========================================== + Hits 140717 140763 +46 - Misses 61709 61754 +45 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.