Errant GTID Counts metric in VTOrc

GuptaManan100 commented 4 days ago

Description

As pointed out in https://github.com/vitessio/vitess/issues/16828, it would be a good idea to also publish the number of errant GTIDs in each tablet as a metric. This PR accomplishes this goal.

The new metric looks like -

"ErrantGTIDCounts": {"zone1-0000000100": 1},

Related Issue(s)

Fixes https://github.com/vitessio/vitess/issues/16828

Checklist

[x] "Backport to:" labels have been added if this change should be back-ported to release branches
[x] If this change is to be back-ported to previous releases, a justification is included in the PR description
[x] Tests were added or are not required
[x] Did the new or modified tests pass consistently locally and on CI?
[x] Documentation was added or is not required

Deployment Notes

vitess-bot[bot] commented 4 days ago

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

[ ] Ensure that the Pull Request has a descriptive title.
[ ] Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

[ ] Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

[ ] Apply the release notes (needs details) label if users need to know about this change.
[ ] New features should be documented.
[ ] There should be some code comments as to why things are implemented the way they are.
[ ] There should be a comment at the top of each new or modified test to explain what the test does.

New flags

[ ] Is this flag really necessary?
[ ] Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

[ ] Each item in Jobs should be named in order to mark it as required.
[ ] If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

[ ] Protobuf changes should be wire-compatible.
[ ] Changes to _vt tables and RPCs need to be backward compatible.
[ ] RPC changes should be compatible with vitess-operator
[ ] If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
[ ] vtctl command output order should be stable and awk-able.

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.53%. Comparing base (95f2e3e) to head (bd70d2d).

Files with missing lines	Patch %	Lines
go/vt/vtorc/inst/instance_dao.go	20.00%	4 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #16829 +/- ## ========================================== + Coverage 69.51% 69.53% +0.02% ========================================== Files 1569 1569 Lines 202517 202531 +14 ========================================== + Hits 140780 140833 +53 + Misses 61737 61698 -39 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vitessio / vitess