Closed GuptaManan100 closed 1 month ago
Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.
release notes (needs details)
label if users need to know about this change.-
), and have a clear help text.Jobs
should be named in order to mark it as required
.required
, the maintainer team must be notified._vt
tables and RPCs need to be backward compatible.vtctl
command output order should be stable and awk
-able.Attention: Patch coverage is 43.28358%
with 38 lines
in your changes missing coverage. Please review.
Project coverage is 69.42%. Comparing base (
766bc64
) to head (e1e560c
). Report is 7 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thank you for the reviews! I've addressed all review comments and added the release notes changes as requested. I will merge the PR once the tests are green. ♥️
Description
This PR adds errant GTID detection logic in
setReplicationSourceLocked
call. The intent is that we want to prevent any replica that has an errant GTID from even joining the replication stream. This is because we want to prevent this replica from sending semi-sync ACKs, which can land us into some really annoying and hard to deal with situations.To do the errant GTID detection, the tablets first query their own position and then ask the primary for its position. Then they compare the two to see if they have an errant GTID or not. If they do, they fail the RPC without setting the new source.
Related Issue(s)
Checklist
Deployment Notes