vitessio / vitess

Vitess is a database clustering system for horizontal scaling of MySQL.
http://vitess.io
Apache License 2.0
18.67k stars 2.1k forks source link

reject atomic distributed transaction on savepoints and modified system settings #16835

Closed harshit-gangal closed 1 month ago

harshit-gangal commented 1 month ago

Description

This PR rejects a Atomic Distributed Transaction Commit when the session have modified system settings or using temporary table or have savepoints inside the transaction.

This will be removed when the support is added for it.

Related Issue(s)

Checklist

vitess-bot[bot] commented 1 month ago

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

Tests

Documentation

New flags

If a workflow is added or modified:

Backward compatibility

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.45%. Comparing base (83b37b8) to head (d3a9131). Report is 14 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #16835 +/- ## ========================================== - Coverage 69.54% 69.45% -0.09% ========================================== Files 1569 1571 +2 Lines 202555 203012 +457 ========================================== + Hits 140865 141001 +136 - Misses 61690 62011 +321 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.