vitessio / vitess

Vitess is a database clustering system for horizontal scaling of MySQL.
http://vitess.io
Apache License 2.0
18.67k stars 2.1k forks source link

Use `go-version-file: go.mod` in CI #16841

Closed timvaillancourt closed 1 month ago

timvaillancourt commented 1 month ago

Description

This PR uses go-version-file: go.mod in CI that requires a go version == go.mod. This makes the repo a bit easier to maintain in places

The only CI files that still have a specific go-version: set are:

Are those set by hand? On main these are set to 1.22.7, a previous-release go version. Also I'm unclear if I've broken go-upgrade (I didn't know about this) and could use a hand validating that part 🤔

Example of go-version-file: go.mod finding 1.23.1 (from this PR CI):

Screenshot 2024-09-24 at 20 24 04

Related Issue(s)

https://github.com/vitessio/vitess/issues/16842

Checklist

Deployment Notes

vitess-bot[bot] commented 1 month ago

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

Tests

Documentation

New flags

If a workflow is added or modified:

Backward compatibility

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.45%. Comparing base (969e018) to head (f8a3984).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #16841 +/- ## ========================================== + Coverage 69.41% 69.45% +0.03% ========================================== Files 1570 1570 Lines 202945 202923 -22 ========================================== + Hits 140880 140940 +60 + Misses 62065 61983 -82 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

systay commented 1 month ago

👏 Very nice!

frouioui commented 1 month ago

@frouioui can you also please take a look?

I will take a look at the go-upgrade in the morning

frouioui commented 1 month ago

Are those set by hand?

Yes, these match the golang version used on the previous release branch. Since the goal of these workflows is to downgrade from main to the latest release branch, we use the go version found there.

timvaillancourt commented 1 month ago

Re-requesting review on last tweak from @frouioui 🙇