Closed timvaillancourt closed 1 month ago
Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.
release notes (needs details)
label if users need to know about this change.-
), and have a clear help text.Jobs
should be named in order to mark it as required
.required
, the maintainer team must be notified._vt
tables and RPCs need to be backward compatible.vtctl
command output order should be stable and awk
-able.All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 69.45%. Comparing base (
969e018
) to head (f8a3984
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
👏 Very nice!
@frouioui can you also please take a look?
I will take a look at the go-upgrade in the morning
Are those set by hand?
Yes, these match the golang version used on the previous release branch. Since the goal of these workflows is to downgrade from main to the latest release branch, we use the go version found there.
Re-requesting review on last tweak from @frouioui 🙇
Description
This PR uses
go-version-file: go.mod
in CI that requires a go version ==go.mod
. This makes the repo a bit easier to maintain in placesThe only CI files that still have a specific
go-version:
set are:.github/workflows/upgrade_downgrade_test_backups_e2e.yml
.github/workflows/upgrade_downgrade_test_backups_manual.yml
.github/workflows/upgrade_downgrade_test_onlineddl_flow.yml
.github/workflows/upgrade_downgrade_test_query_serving_queries.yml
.github/workflows/upgrade_downgrade_test_query_serving_schema.yml
.github/workflows/upgrade_downgrade_test_reparent_old_vtctl.yml
.github/workflows/upgrade_downgrade_test_reparent_old_vttablet.yml
.github/workflows/upgrade_downgrade_test_semi_sync.yml
Are those set by hand? On
main
these are set to1.22.7
, a previous-release go version. Also I'm unclear if I've brokengo-upgrade
(I didn't know about this) and could use a hand validating that part 🤔Example of
go-version-file: go.mod
finding1.23.1
(from this PR CI):Related Issue(s)
https://github.com/vitessio/vitess/issues/16842
Checklist
Deployment Notes