Open shlomi-noach opened 2 days ago
Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.
release notes (needs details)
label if users need to know about this change.-
), and have a clear help text.Jobs
should be named in order to mark it as required
.required
, the maintainer team must be notified._vt
tables and RPCs need to be backward compatible.vtctl
command output order should be stable and awk
-able.Attention: Patch coverage is 42.10526%
with 55 lines
in your changes missing coverage. Please review.
Project coverage is 69.41%. Comparing base (
4058966
) to head (338c52c
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Addresses https://github.com/vitessio/vitess/issues/16822. This is part of the multi-metrics throttler project.
Part 1, to be included in
v21
:mysqlctl.SystemMetrics
RPC, which returns a map[metric-name]metric-value, e.g.metrics["loadavg"]={...Value: 1.234}
tabletmanager.MysqlSystemMetrics
, which is an access point to the above.TabletManager
is the entity that holds aMysqlDaemon
, thus is the only one able to callmysqlctl.SystemMetrics
RPC.TabletManagerClient
supportsMysqlSystemMetrics()
function, so that anyone can query a given tablet for its MySQL OS metrics.This is all wired in this PR, ie if you call
tmclient. TabletManagerClient
, you get the actual OS metrics read by MysqlDaemon.However, for 1-version backwards compatibility, this code path is not used anywhere.
We wish to merge this in
v21
, and immediately follow up with a PR (designed forv22
) where the tablet throttler collects these metrics. IT will do so sparsely.Related Issue(s)
Checklist
Deployment Notes