Add `ChangeTabletTags` RPC to `vtctl`, `ChangeTags` RPC to `vttablet`

timvaillancourt commented 1 day ago

Description

As discussed in https://github.com/vitessio/vitess/issues/16377, this PR implements a new vtctld and corresponding vttablet RPC to allow the tags of a tablet to be changed

VTCtld RPC: ChangeTabletTags
VTTablet RPC: ChangeTags

The new RPC supports both replacing and merging the existing tags. This merging happens on the tablet under a lock

CLI

tim@Tims-MacBook-Pro vitess % ./bin/vtctldclient ChangeTabletTags --help 2>&1 | head       
Changes the tablet tags for the specified tablet, if possible.

Tags must be specified as key=value pairs.

Usage:
  vtctldclient ChangeTabletTags <alias> <tablet-tag> [ <tablet-tag> ... ]

Flags:
  -h, --help      help for ChangeTabletTags
  -r, --replace   Replace all tablet tags with the tags provided. By default tags are merged/updated.

Related Issue(s)

https://github.com/vitessio/vitess/issues/16377

Checklist

[x] "Backport to:" labels have been added if this change should be back-ported to release branches
[x] If this change is to be back-ported to previous releases, a justification is included in the PR description
[x] Tests were added or are not required
[x] Did the new or modified tests pass consistently locally and on CI?
[ ] Documentation was added or is not required

Deployment Notes

vitess-bot[bot] commented 1 day ago

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

[ ] Ensure that the Pull Request has a descriptive title.
[ ] Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

[ ] Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

[ ] Apply the release notes (needs details) label if users need to know about this change.
[ ] New features should be documented.
[ ] There should be some code comments as to why things are implemented the way they are.
[ ] There should be a comment at the top of each new or modified test to explain what the test does.

New flags

[ ] Is this flag really necessary?
[ ] Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

[ ] Each item in Jobs should be named in order to mark it as required.
[ ] If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

[ ] Protobuf changes should be wire-compatible.
[ ] Changes to _vt tables and RPCs need to be backward compatible.
[ ] RPC changes should be compatible with vitess-operator
[ ] If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
[ ] vtctl command output order should be stable and awk-able.

codecov[bot] commented 20 hours ago

Codecov Report

Attention: Patch coverage is 5.83333% with 113 lines in your changes missing coverage. Please review.

Project coverage is 69.40%. Comparing base (2e2b223) to head (03a26d1). Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
go/vt/vtctl/grpcvtctldserver/server.go	0.00%	20 Missing :warning:
go/cmd/vtctldclient/command/tablets.go	9.52%	19 Missing :warning:
go/vt/vttablet/tabletmanager/rpc_actions.go	0.00%	13 Missing :warning:
go/vt/vttablet/grpctmclient/client.go	0.00%	12 Missing :warning:
go/vt/vttablet/tmrpctest/test_tm_rpc.go	0.00%	12 Missing :warning:
go/cmd/vtctldclient/cli/tablets.go	0.00%	10 Missing :warning:
go/vt/vttablet/grpctmserver/server.go	0.00%	7 Missing :warning:
go/vt/vttablet/tabletmanager/tm_state.go	0.00%	7 Missing :warning:
go/vt/vtcombo/tablet_map.go	0.00%	5 Missing :warning:
go/vt/vtctl/grpcvtctldclient/client_gen.go	0.00%	4 Missing :warning:
... and 2 more

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #16857 +/- ## ========================================== - Coverage 69.43% 69.40% -0.04% ========================================== Files 1571 1571 Lines 203021 203193 +172 ========================================== + Hits 140970 141017 +47 - Misses 62051 62176 +125 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vitessio / vitess