vitessio / vitess

Vitess is a database clustering system for horizontal scaling of MySQL.
http://vitess.io
Apache License 2.0
18.67k stars 2.1k forks source link

[release-21.0] VReplication: Qualify and SQL escape tables in created AutoIncrement VSchema definitions (#17174) #17176

Closed vitess-bot[bot] closed 1 week ago

vitess-bot[bot] commented 1 week ago

Description

This is a backport of #17174

vitess-bot[bot] commented 1 week ago

Hello @mattlord, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote


git fetch --all
gh pr checkout 17176 -R vitessio/vitess
git reset --hard origin/release-21.0
git cherry-pick -m 1 31b956b637373ca8b14249e6f854d5eadc271775
vitess-bot[bot] commented 1 week ago

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

Tests

Documentation

New flags

If a workflow is added or modified:

Backward compatibility

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 60.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 67.51%. Comparing base (5fbbb8e) to head (66711ea). Report is 2 commits behind head on release-21.0.

Files with missing lines Patch % Lines
go/vt/vtctl/workflow/materializer.go 64.70% 6 Missing :warning:
go/vt/vtctl/workflow/utils.go 50.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-21.0 #17176 +/- ## ============================================= Coverage 67.51% 67.51% ============================================= Files 1570 1570 Lines 251283 251298 +15 ============================================= + Hits 169642 169673 +31 + Misses 81641 81625 -16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.