Open derekperkins opened 1 week ago
Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.
release notes (needs details)
label if users need to know about this change.-
), and have a clear help text.Jobs
should be named in order to mark it as required
.required
, the maintainer team must be notified._vt
tables and RPCs need to be backward compatible.vtctl
command output order should be stable and awk
-able.Attention: Patch coverage is 86.04651%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 67.31%. Comparing base (
f6ca94f
) to head (fb6115e
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
go/sqltypes/value.go | 85.36% | 6 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
there are already conversions for other native types, but datetime conversions were only available in the vitessdriver. This moves that implementation into sqltypes, so it can be more easily accessed elsewhere. I'm specifically interested in using this with VStream.
The actual implementation was done by @vmg in the driver in 2017, so this just moves it into the sqltypes package, adding a similar
ToTime
method onValue
Checklist