vitessio / vitess

Vitess is a database clustering system for horizontal scaling of MySQL.
http://vitess.io
Apache License 2.0
18.67k stars 2.1k forks source link

[release-20.0] Close zookeeper topo connection on disconnect (#17136) #17192

Closed vitess-bot[bot] closed 1 week ago

vitess-bot[bot] commented 1 week ago

Description

This is a backport of #17136

vitess-bot[bot] commented 1 week ago

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

Tests

Documentation

New flags

If a workflow is added or modified:

Backward compatibility

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.42%. Comparing base (3444a1d) to head (7fee093). Report is 1 commits behind head on release-20.0.

Files with missing lines Patch % Lines
go/vt/topo/zk2topo/zk_conn.go 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-20.0 #17192 +/- ## ============================================= Coverage 66.41% 66.42% ============================================= Files 1541 1541 Lines 243990 243986 -4 ============================================= + Hits 162055 162072 +17 + Misses 81935 81914 -21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.