Closed frouioui closed 5 days ago
Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.
release notes (needs details)
label if users need to know about this change.-
), and have a clear help text.Jobs
should be named in order to mark it as required
.required
, the maintainer team must be notified._vt
tables and RPCs need to be backward compatible.vtctl
command output order should be stable and awk
-able.All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.39%. Comparing base (
f6067e0
) to head (30dae54
). Report is 6 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
We should add an end-to-end test that asserts that this works well
Description
This PR fixes a regression introduced by https://github.com/vitessio/vitess/pull/15107, when a user is using (
use ks
) a sharded keyspace that has a reference table with its source in an unsharded keyspace, the query planner would not set the target keyspace correctly when rewriting the query graph, leading to the following plan:This plan ultimately leads to a failure in the engine as we cannot execute updates with a
reference
OpCode: https://github.com/vitessio/vitess/blob/e3d2e89ab4d1b661ff935bbee79c4d6647e19621/go/vt/vtgate/engine/update.go#L65-L73This PR makes sure we are setting the target keyspace correctly.
Must be backported to 20 and 21.