Add support for receiving `grpc_bind_adress` on `vttestserver`

gmpify commented 1 week ago

Description

When --grpc_bind_address is supplied to vttestserver, it is now forwarded up to vtcombo.

Related Issue(s)

Part of https://github.com/vitessio/vitess/issues/16798

Checklist

[ ] "Backport to:" labels have been added if this change should be back-ported to release branches
[ ] If this change is to be back-ported to previous releases, a justification is included in the PR description
[ ] Tests were added or are not required
[ ] Did the new or modified tests pass consistently locally and on CI?
[ ] Documentation was added or is not required

Deployment Notes

vitess-bot[bot] commented 1 week ago

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

[ ] Ensure that the Pull Request has a descriptive title.
[ ] Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

[ ] Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

[ ] Apply the release notes (needs details) label if users need to know about this change.
[ ] New features should be documented.
[ ] There should be some code comments as to why things are implemented the way they are.
[ ] There should be a comment at the top of each new or modified test to explain what the test does.

New flags

[ ] Is this flag really necessary?
[ ] Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

[ ] Each item in Jobs should be named in order to mark it as required.
[ ] If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

[ ] Protobuf changes should be wire-compatible.
[ ] Changes to _vt tables and RPCs need to be backward compatible.
[ ] RPC changes should be compatible with vitess-operator
[ ] If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
[ ] vtctl command output order should be stable and awk-able.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.40%. Comparing base (3499a77) to head (bc26c47). Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
go/vt/vttest/vtprocess.go	88.88%	2 Missing :warning:
go/vt/vttest/local_cluster.go	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #17231 +/- ## ======================================= Coverage 67.39% 67.40% ======================================= Files 1570 1570 Lines 252903 252915 +12 ======================================= + Hits 170451 170466 +15 + Misses 82452 82449 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

vitessio / vitess