vitessio / vitess

Vitess is a database clustering system for horizontal scaling of MySQL.
http://vitess.io
Apache License 2.0
18.7k stars 2.1k forks source link

Refactor `Server.LookupVindexCreate` #17242

Open beingnoble03 opened 5 days ago

beingnoble03 commented 5 days ago

Description

This PR is based on #17092. Mainly refactors prepareCreateLookup().

Related Issue(s)

Checklist

Deployment Notes

vitess-bot[bot] commented 5 days ago

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

Tests

Documentation

New flags

If a workflow is added or modified:

Backward compatibility

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 83.92652% with 140 lines in your changes missing coverage. Please review.

Project coverage is 67.46%. Comparing base (de16aff) to head (d914e1c). Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtctl/workflow/workflows.go 80.30% 89 Missing :warning:
go/vt/vtctl/workflow/lookup.go 88.40% 45 Missing :warning:
go/vt/vtctl/workflow/server.go 80.64% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #17242 +/- ## ========================================== + Coverage 67.33% 67.46% +0.12% ========================================== Files 1569 1572 +3 Lines 252506 252932 +426 ========================================== + Hits 170021 170633 +612 + Misses 82485 82299 -186 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.