Open beingnoble03 opened 5 days ago
Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.
release notes (needs details)
label if users need to know about this change.-
), and have a clear help text.Jobs
should be named in order to mark it as required
.required
, the maintainer team must be notified._vt
tables and RPCs need to be backward compatible.vtctl
command output order should be stable and awk
-able.Attention: Patch coverage is 83.92652%
with 140 lines
in your changes missing coverage. Please review.
Project coverage is 67.46%. Comparing base (
de16aff
) to head (d914e1c
). Report is 20 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
This PR is based on #17092. Mainly refactors
prepareCreateLookup()
.Related Issue(s)
16499
Checklist
Deployment Notes