A couple `endtoend` cluster tests enhancement

shlomi-noach commented 3 days ago

Description

This PR adds two enhancements in go/test/endtoend/cluster:

VtctldClientProcess supports Quiet mode, where it does not log the command line invocation to standard output. The Quiet field is not thread safe. This will be useful to reduce log clutter. I especially intend to use it to reduce CheckThrottler logs.
VttabletProcess supports MultiQueryTablet(), complementing MultiQueryTabletWithDB(). This can be used to issue non-DB specific multi-query SQL from external source.

Related Issue(s)

No issue for this PR.

Checklist

[ ] "Backport to:" labels have been added if this change should be back-ported to release branches
[ ] If this change is to be back-ported to previous releases, a justification is included in the PR description
[ ] Tests were added or are not required
[ ] Did the new or modified tests pass consistently locally and on CI?
[ ] Documentation was added or is not required

Deployment Notes

vitess-bot[bot] commented 3 days ago

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

[ ] Ensure that the Pull Request has a descriptive title.
[ ] Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

[ ] Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

[ ] Apply the release notes (needs details) label if users need to know about this change.
[ ] New features should be documented.
[ ] There should be some code comments as to why things are implemented the way they are.
[ ] There should be a comment at the top of each new or modified test to explain what the test does.

New flags

[ ] Is this flag really necessary?
[ ] Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

[ ] Each item in Jobs should be named in order to mark it as required.
[ ] If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

[ ] Protobuf changes should be wire-compatible.
[ ] Changes to _vt tables and RPCs need to be backward compatible.
[ ] RPC changes should be compatible with vitess-operator
[ ] If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
[ ] vtctl command output order should be stable and awk-able.

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.40%. Comparing base (216fd70) to head (54a7ad0).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #17247 +/- ## ========================================== + Coverage 67.39% 67.40% +0.01% ========================================== Files 1570 1570 Lines 252917 252917 ========================================== + Hits 170446 170490 +44 + Misses 82471 82427 -44 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vitessio / vitess