Handle MySQL handler error codes

shlomi-noach commented 6 days ago

Description

Some of MySQL errors include more fine grained handler error codes, as seen in

bld/include/mysqld_ername.h:205:{ "ER_ERROR_DURING_COMMIT", 1180, "Got error %d - \'%-.192s\' during COMMIT","HY000", "", 162 },

For example: ERROR HY000: Got error 149 - 'Lock deadlock; Retry transaction' during COMMIT

Another example: ER_ERROR_DURING_COMMIT as described in https://github.com/vitessio/vitess/issues/17248.

With this PR we formally introduce HandlerErrorCode. We add SQLError.HaErrorCode() which uses regexp parsing on the error message to extract the handler error code, if any.

Furthermore, some of these handler error codes indicate an unrecoverable error for vreplication. ~~We meanwhile add a sample of those.~~ We list the full range of existing HA errors, and mark a select few as recoverable.

Related Issue(s)

https://github.com/vitessio/vitess/issues/17248

Checklist

[ ] "Backport to:" labels have been added if this change should be back-ported to release branches
[ ] If this change is to be back-ported to previous releases, a justification is included in the PR description
[ ] Tests were added or are not required
[ ] Did the new or modified tests pass consistently locally and on CI?
[ ] Documentation was added or is not required

Deployment Notes

vitess-bot[bot] commented 6 days ago

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

[ ] Ensure that the Pull Request has a descriptive title.
[ ] Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

[ ] Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

[ ] Apply the release notes (needs details) label if users need to know about this change.
[ ] New features should be documented.
[ ] There should be some code comments as to why things are implemented the way they are.
[ ] There should be a comment at the top of each new or modified test to explain what the test does.

New flags

[ ] Is this flag really necessary?
[ ] Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

[ ] Each item in Jobs should be named in order to mark it as required.
[ ] If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

[ ] Protobuf changes should be wire-compatible.
[ ] Changes to _vt tables and RPCs need to be backward compatible.
[ ] RPC changes should be compatible with vitess-operator
[ ] If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
[ ] vtctl command output order should be stable and awk-able.

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.42%. Comparing base (216fd70) to head (cb99a24). Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
go/mysql/sqlerror/constants.go	0.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #17252 +/- ## ========================================== + Coverage 67.39% 67.42% +0.02% ========================================== Files 1570 1570 Lines 252917 252934 +17 ========================================== + Hits 170446 170529 +83 + Misses 82471 82405 -66 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

vitessio / vitess