Open shlomi-noach opened 2 days ago
Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.
release notes (needs details)
label if users need to know about this change.-
), and have a clear help text.Jobs
should be named in order to mark it as required
.required
, the maintainer team must be notified._vt
tables and RPCs need to be backward compatible.vtctl
command output order should be stable and awk
-able.All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.40%. Comparing base (
3499a77
) to head (88b8b61
). Report is 3 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
As expected, all checks pass.
Description
Looking to see if/which tests fail if we do not close the connection on commit error. I suspect nothing will fail in the tests, because this particular error is so rare. Let's see what happens and continue the investigation from there on.
Related Issue(s)
https://github.com/vitessio/vitess/issues/17248
Checklist
Deployment Notes