vitessio / vitess

Vitess is a database clustering system for horizontal scaling of MySQL.
http://vitess.io
Apache License 2.0
18.7k stars 2.1k forks source link

EXPERIMENTAL: do not close binlog connection on commit error #17253

Open shlomi-noach opened 2 days ago

shlomi-noach commented 2 days ago

Description

Looking to see if/which tests fail if we do not close the connection on commit error. I suspect nothing will fail in the tests, because this particular error is so rare. Let's see what happens and continue the investigation from there on.

Related Issue(s)

https://github.com/vitessio/vitess/issues/17248

Checklist

Deployment Notes

vitess-bot[bot] commented 2 days ago

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

Tests

Documentation

New flags

If a workflow is added or modified:

Backward compatibility

codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.40%. Comparing base (3499a77) to head (88b8b61). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #17253 +/- ## ======================================= Coverage 67.39% 67.40% ======================================= Files 1570 1570 Lines 252903 252933 +30 ======================================= + Hits 170451 170489 +38 + Misses 82452 82444 -8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

shlomi-noach commented 2 days ago

As expected, all checks pass.