Ship `./test/bin/rippled` as static binary or remove it entirely

vitessio / vitess

Vitess is a database clustering system for horizontal scaling of MySQL.

http://vitess.io

Apache License 2.0

18.64k stars 2.1k forks source link

Ship `./test/bin/rippled` as static binary or remove it entirely #7211

Open adsr opened 3 years ago

adsr commented 3 years ago

Shipping a dynamically-linked binary hurts portability. For example we're unable to run it on CentOS 7 as it relies on a newer version of libstdc++ than available. Ideally we can figure out a way to remove the binary entirely. If not, can we a ship a static binary in the mean time? (I tried a quick static build of mysql-ripple[0] but the build fails on my machine.)

[0] https://github.com/google/mysql-ripple/blob/master/BUILD.bazel

shlomi-noach commented 3 years ago

To the best of my understanding rippled is strictly experimental and is not being used at this time. Did you happen to just notice this or is anything failing for you somewhere?

adsr commented 3 years ago

Hi @shlomi-noach. We encountered this as a failed rpm dep check while upgrading our internal rpm. (We ship a "fat rpm" that contains deps pulled in by bootstrap.sh, build artifacts, and the original source tree.) Fix for us was to remove rippled at rpm build time.