vitessio / website

vitess.io website and other project management related content
https://vitess.io
Apache License 2.0
53 stars 198 forks source link

Vitess 17 Local Install instructions not working - bis. #1523

Closed jfg956 closed 1 year ago

jfg956 commented 1 year ago

Bis because of {1} (Vitess 17 Local Install instructions not working).

{1}: https://github.com/vitessio/website/issues/1520

Same context as in {1}, source ./env.sh not working in {2}. My guess is that it should be source ../common/env.sh.

{2}: https://vitess.io/docs/17.0/get-started/local/#setup-aliases

$ pwd
/home/jgagne/my-vitess-example/examples/local
$ source ./env.sh
bash: ./env.sh: No such file or directory
$ grep source 101_initial_cluster.sh
source ../common/env.sh
$ source ../common/env.sh
$

I might submit a PR for this when I am done with exploring Vitess 17.

Below added after opening the bug...

Probably similar errors in Vitess 16 {3}, but not in Vitess 15 as it has env.sh in local.

{3}: https://vitess.io/docs/16.0/get-started/local/#setup-aliases

$ grep source vitess-16.0.2-6076fed/examples/local/101_initial_cluster.sh
source ../common/env.sh
$ test -e vitess-16.0.2-6076fed/examples/local/env.sh || echo does not exists
does not exists

Also, in {4}, I see ~/my-vitess-example> mysql but in {5} we cd ~/my-vitess-example/examples/local, so it should be ~/my-vitess-example/examples/local> mysql. This error repeats many places in {6} and in the the v16 and v15 versions of this page ({7} and {8}). I would suggest fixing this by not includinf pwd in the prompt for making this less error-prone and easier to understand.

{4}: https://vitess.io/docs/17.0/get-started/local/#start-a-single-keyspace-cluster {5}: https://vitess.io/docs/17.0/get-started/local/#start-a-single-keyspace-cluster {6}: https://vitess.io/docs/17.0/get-started/local/ {7}: https://vitess.io/docs/16.0/get-started/local/ {8}: https://vitess.io/docs/15.0/get-started/local/