[ ] Document --keep_data behavior for Complete. Right now it only covers Cancel.
[ ] Is --rename_tables relevant for Reshard? Docs say so. If not, this should be fixed.
[ ] Reshard Complete says By default, the source tables are also dropped on the source shards. This seems to have been copied from MoveTables. What exactly do we drop on Complete? We don't actually tear down vttablets, so I'd assume nothing except vreplication related metadata.
List of minor improvements / missing things from docs at https://vitess.io/docs/18.0/reference/vreplication/movetables/ and https://vitess.io/docs/18.0/reference/vreplication/reshard/
--keep_data
behavior forComplete
. Right now it only coversCancel
.--rename_tables
relevant forReshard
? Docs say so. If not, this should be fixed.Reshard Complete
saysBy default, the source tables are also dropped on the source shards
. This seems to have been copied fromMoveTables
. What exactly do we drop onComplete
? We don't actually tear down vttablets, so I'd assume nothing except vreplication related metadata.