vitessio / website

vitess.io website and other project management related content
https://vitess.io
Apache License 2.0
54 stars 204 forks source link

Docs: using `vtctldclient` in all Online DDL -related examples #1622

Closed shlomi-noach closed 11 months ago

shlomi-noach commented 11 months ago

Followup to https://github.com/vitessio/website/pull/1619

Switching from vtctl/vtctlclient based examples to vtctldclient.

netlify[bot] commented 11 months ago

Deploy Preview for vitess ready!

Name Link
Latest commit 24ee89e84f2108be65dba8942a7f21dd6088d1e4
Latest deploy log https://app.netlify.com/sites/vitess/deploys/6534bf4e720ca20007e51913
Deploy Preview https://deploy-preview-1622--vitess.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

shlomi-noach commented 11 months ago

I've addressed all comments except this one, which I did not fully understand:

I would generalize with ddl strategy as a way to include --ddl-strategy

shlomi-noach commented 11 months ago

I've completed all changes to the docs, and have copied the changes back to 18.0 docs.

mattlord commented 11 months ago

I've completed all changes to the docs, and have copied the changes back to 18.0 docs.

Thanks! 🚢