search

vitessio / website

vitess.io website and other project management related content
https://vitess.io
Apache License 2.0
54 stars 204 forks source link

Docs: Backup/BackupShard --incremental-from-pos accepts backup name #1662

Closed shlomi-noach closed 8 months ago

shlomi-noach commented 8 months ago

This PR documents the changes in https://github.com/vitessio/vitess/pull/14923, --incremental-from-pos accepting a backup name.

There is a lot of noise because of SHA signatures. The relevant changes are mostly in content/en/docs/19.0/user-guides/operating-vitess/backup-and-restore/creating-a-backup.md and otherwise in vtctl and vtctldclient docs.

netlify[bot] commented 8 months ago

Deploy Preview for vitess ready!

Name Link
Latest commit 10340cad3544c509baab56797853385884cabb44
Latest deploy log https://app.netlify.com/sites/vitess/deploys/65a37be7f713b50008e06d7d
Deploy Preview https://deploy-preview-1662--vitess.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mattlord commented 8 months ago

We only need to update the non-auto-generated pages here as the vtctldclient reference pages happen automatically based on the client binary output. I.e. we only need to update the user guide and vtctl[client] pages. Can you please remove the other changes so that it's easier to review?

shlomi-noach commented 8 months ago

We only need to update the non-auto-generated pages here as the vtctldclient reference pages happen automatically based on the client binary output. I.e. we only need to update the user guide and vtctl[client] pages.

That's what happens when I auto-generate the docs. I've been at it for many PRs now, I'm told this "just works" but clearly I didn't make all these changes manually...

ajm188 commented 8 months ago

@mattlord see https://github.com/vitessio/website/issues/1602#issuecomment-1855882870

shlomi-noach commented 8 months ago

Looking back at my own comment I don't like how it reads. I'm sorry about that, it gives a wrong impression. At any case, please let me know how to proceed otherwise.

mattlord commented 8 months ago

@mattlord see #1602 (comment)

I did see that but didn't realize that it was still broken. Sorry about that.

shlomi-noach commented 8 months ago

This branch is a mess. Replacing with a new PR.