search

vitessio / website

vitess.io website and other project management related content
https://vitess.io
Apache License 2.0
47 stars 187 forks source link

fix(supported-databases): update 8.0 to 8.0.* to make it clear to people any version of 8.0.* should work. #1710

Closed dbmurphy closed 1 month ago

dbmurphy commented 3 months ago

fix(supported-databases): update 8.0 to 8.0. to make it clear to people any version of 8.0. should work.

netlify[bot] commented 3 months ago

Deploy Preview for vitess ready!

Name Link
Latest commit ab988907a17d7b683bbdef63c8fb9b06704d8989
Latest deploy log https://app.netlify.com/sites/vitess/deploys/65fc8148e519460008e2d563
Deploy Preview https://deploy-preview-1710--vitess.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

deepthi commented 3 months ago

I know this was discussed on slack, and I'm kind of with Matt here. MySQL 8.0 is understood to mean to include all minor versions, so I don't see the need to add a *.

dbmurphy commented 3 months ago

I know this was discussed on slack, and I'm kind of with Matt here. MySQL 8.0 is understood to mean to include all minor versions, so I don't see the need to add a *.

If that's how you see it, I can't help, but I was clear that multiple people in our organization see it differently, so it is a problem for people who are not as close to the product as we are. I think where @mattlord and I landed, it doesn't hurt anything to add the * to be more precise for others, especially in business and security roles.

The comments were along lines such as "It's ambiguous and unclear if there may be any 8.0.* version or a specific one listed elsewhere" or "Can we only use the 8.0 that they used in the example, which did not change from v18.0 to v19.0"?

deepthi commented 1 month ago

multiple people in our organization see it differently, so it is a problem for people who are not as close to the product as we are.

OK, this is a valid argument. We want docs to be clear to people who might be coming new to them, so let's go ahead and merge this.