Fails to run / parse `.cts` source files.

Jason3S commented 1 year ago

Describe the bug

While working with an application with a mix of .mts and .cts files, vitest fails to correctly parse the .cts source files. It seems to be treating them as .cjs files.

Reproduction

https://stackblitz.com/edit/vitest-dev-vitest-xrug9w?file=README.md

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.20.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 9.4.2 - /usr/local/bin/npm
    pnpm: 8.6.10 - /usr/local/bin/pnpm
  npmPackages:
    @vitest/ui: latest => 0.34.2 
    vite: latest => 4.4.9 
    vitest: latest => 0.34.2

Used Package Manager

npm

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

stackblitz[bot] commented 1 year ago

Start a new pull request in StackBlitz Codeflow.

vitest-dev-vitest-xrug9w (Open reproduction)

sheremet-va commented 1 year ago

Interesting. Vite doesn't process .cts files at all. I guess we should provide our own plugin to transform this?

I am not sure if we should even support generated CJS, since we cannot process require calls there (if in your example you had import test from './test.cts' it would've been transformed into a require('./test.cjs'), and Vitest doesn't intercept require at all because Vite's plugin system is asynchronous, so it would try to run TypeScript file as a JavaScript file and we wouldn't be able to do anything.

I would recommend running tests on already transformed files in your case.

Jason3S commented 1 year ago

Note: One workaround I found was to compile the .cts files in place (into the same dir) to .cjs file. But this breaks down when trying to generate a coverage report.

Example Setup: https://github.com/streetsidesoftware/cspell/tree/main/packages/cspell/src/lib

wijionejs commented 1 year ago

Note: One workaround I found was to compile the .cts files in place (into the same dir) to .cjs file. But this breaks down when trying to generate a coverage report.

Example Setup: https://github.com/streetsidesoftware/cspell/tree/main/packages/cspell/src/lib

Here is a library that may help you to intercept and mock require calls: vitest-mock-require