Vitest not working with uwebsockets.js

chanon commented 5 months ago

Describe the bug

Just calling uwebsocket's App() will terminate the test and Vitest will not show results of any tests.

I have tried looking through the Vitest documentation to see what the problem could be, but did not find anything.

Reproduction

Complete minimal reproduction in github repo: https://github.com/chanon/vitest-uws/

The test code in tests/minimal.test.ts:

import { test } from "vitest"
import { App } from 'uWebSockets.js'

test("test it", async () => {
    try {
        console.log('before App()')
        // try commenting out the App() call
        App()
        console.log('after App()')
    }
    catch (e) {
        console.log(e)
    }
})

Run

pnpm install
pnpm vitest

Result:

Comment App() call and run again.

Result:

System Info

(Relevant info:)

 System:
    OS: Windows 10 
  Binaries:
    Node: 20.9.0
    pnpm: 9.0.4

Used Package Manager

pnpm

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

AriPerkkio commented 5 months ago

Tested this on Github Codespaces and it works fine there. Does vitest --pool=forks make this work better on Windows?

chanon commented 5 months ago

Aha! yes. That works. I somehow missed that in the docs.

AriPerkkio commented 5 months ago

The uWebSockets.js seems to be native node addon. Those have some compatibility issues with Vitest's default pool. In the next major we'll be defaulting to pool: 'forks' so that this kind of issues would not come up: https://github.com/vitest-dev/vitest/pull/5047

vitest-dev / vitest