vitest-dev / vitest

Next generation testing framework powered by Vite.
https://vitest.dev
MIT License
13.03k stars 1.17k forks source link

`BaseSequencer` class uses deprecated type `WorkspaceSpec` #6752

Closed eskylake closed 2 weeks ago

eskylake commented 2 weeks ago

Describe the bug

BaseSequencer class uses WorkspaceSpec type, marked as @deprecated.

https://github.com/vitest-dev/vitest/blob/63f8b07042e9885d74daca7e175351c47078b99a/packages/vitest/src/node/sequencers/BaseSequencer.ts#L5

Reproduction

You should see a warning about using the deprecated WorkspaceSpec type during the build process.

System Info

System:
    OS: Linux 6.8 Ubuntu 22.04.5 LTS 22.04.5 LTS (Jammy Jellyfish)
    CPU: (12) x64 11th Gen Intel(R) Core(TM) i5-11400H @ 2.70GHz
    Memory: 3.77 GB / 15.40 GB
    Container: Yes
    Shell: 5.8.1 - /usr/bin/zsh
  Binaries:
    Node: 20.12.1 - ~/.volta/tools/image/node/20.12.1/bin/node
    Yarn: 3.7.0 - ~/.volta/tools/image/yarn/3.7.0/bin/yarn
    npm: 10.5.0 - ~/.volta/tools/image/node/20.12.1/bin/npm
    bun: 0.1.5 - ~/.bun/bin/bun
  Browsers:
    Brave Browser: 130.1.71.114
    Chrome: 130.0.6723.58
    Chromium: 129.0.6668.100
  npmPackages:
    @vitest/coverage-v8: ^2 => 2.1.1 
    vitest: ^2 => 2.1.3

Used Package Manager

yarn

Validations

sheremet-va commented 2 weeks ago

What is the problem? It uses deprecated object because the arguments will change in Vitest 3, we can't just replace it.