search

vitest-dev / vscode

VS Code extension for Vitest
https://vitest.dev/vscode
MIT License
736 stars 83 forks source link

Default `NODE_ENV` to `test` #346

Closed john-griffin closed 4 months ago

john-griffin commented 4 months ago

Followup to https://github.com/vitest-dev/vscode/pull/309

When running the extension on a fresh install I could see the NODE_ENV by default is coming through as true. If we want to match the behavior of startVitest in https://github.com/vitest-dev/vitest/blob/5c7e9ca05491aeda225ce4616f06eefcd068c0b4/packages/vitest/src/node/cli/cli-api.ts#L40 we should default to test.

sheremet-va commented 4 months ago

Thanks 👍🏻

hi-ogawa commented 4 months ago

Omg, bad typo... Thanks for the fix!